hazaar/framework
1
0
Fork 0
Code Issues 14 Pull requests 1 Projects Releases Packages 1 Wiki Activity Actions

Select list "loading..." placeholder doesn't seem to work... #102

New issue
Closed
opened 2017-11-13 01:16:22 +00:00 by jamie · 6 comments
jamie commented 2017-11-13 01:16:22 +00:00 (Migrated from git.hazaar.io)
Copy link

Not sure when this broke, but it doesn't seem to work anymore.

When a select listis loading it's options via AJAX it should display "loading..." as the only/selected option.

Not sure when this broke, but it doesn't seem to work anymore. When a select listis loading it's options via AJAX it should display "loading..." as the only/selected option.
jamie commented 2017-11-13 01:16:27 +00:00 (Migrated from git.hazaar.io)
Copy link

added hazaar-forms~167 label

added hazaar-forms~167 label
jamie commented 2017-11-13 01:56:31 +00:00 (Migrated from git.hazaar.io)
Copy link

This is originally from hazaar/hazaar-forms#48 but turned out to be an issue in the dataBinder JS class. When the dataBinder.resync() is called it is setting the select list to a value that doesn't actually exist. We need to add a check to make sure the option exists before setting it as the value. If it doesn't exist, then just leave it as is. In the case of the original issue "leaving it as is" will leave the "loading..." option selected.

This is originally from hazaar/hazaar-forms#48 but turned out to be an issue in the dataBinder JS class. When the `dataBinder.resync()` is called it is setting the select list to a value that doesn't actually exist. We need to add a check to make sure the option exists before setting it as the value. If it doesn't exist, then just leave it as is. In the case of the original issue "leaving it as is" will leave the "loading..." option selected.
jamie commented 2017-11-13 02:30:25 +00:00 (Migrated from git.hazaar.io)
Copy link

created branch 102-select-list-loading-placeholder-doesn-t-seem-to-work

created branch [`102-select-list-loading-placeholder-doesn-t-seem-to-work`](https://git.hazaarlabs.com/hazaar/hazaar-mvc/compare/master...102-select-list-loading-placeholder-doesn-t-seem-to-work)
jamie commented 2017-11-13 02:30:27 +00:00 (Migrated from git.hazaar.io)
Copy link

mentioned in merge request !18

mentioned in merge request !18
jamie commented 2017-11-13 02:31:00 +00:00 (Migrated from git.hazaar.io)
Copy link

closed via merge request !18

closed via merge request !18
jamie commented 2018-06-29 02:25:36 +00:00 (Migrated from git.hazaar.io)
Copy link

changed milestone to %4

changed milestone to %4
jamie self-assigned this 2025-09-04 01:15:51 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
586-gitlab-ci-migration
297-feature-router-security
develop
No results found.
Labels
Clear labels   
bug

   
confirmed

   
critical

   
discussion

   
documentation

   
Doing

   
enhancement

   
experiment

Experimental Feature

  
suggestion

   
support

   
Testing

   
To Do
No labels
bug
confirmed
critical
discussion
documentation
Doing
enhancement
experiment
suggestion
support
Testing
To Do
Milestone
Clear milestone
No items
No milestone
Release 2.4
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
jamie
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: hazaar/framework#102
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?