hazaar/framework
1
0
Fork 0
Code Issues 14 Pull requests 1 Projects Releases Packages 1 Wiki Activity Actions

Hazaar\Dir::read() should return an object of the correct type #160

New issue
Closed
opened 2019-02-21 05:57:45 +00:00 by jamie · 4 comments
jamie commented 2019-02-21 05:57:45 +00:00 (Migrated from git.hazaar.io)
Copy link

Currently, this only returns Hazaar\File objects, but if the child is a directory, then why not return a Hazaar\File\Dir object?

This will only work if I can do it without initiating another check on the backend, so the is_dir flag has to be sent with the initial data.

Currently, this only returns `Hazaar\File` objects, but if the child is a directory, then why not return a `Hazaar\File\Dir` object? This will only work if I can do it without initiating another check on the backend, so the `is_dir` flag has to be sent with the initial data.
jamie commented 2019-02-21 22:08:47 +00:00 (Migrated from git.hazaar.io)
Copy link

created merge request !58 to address this issue

created merge request !58 to address this issue
jamie commented 2019-02-21 22:08:56 +00:00 (Migrated from git.hazaar.io)
Copy link

mentioned in merge request !58

mentioned in merge request !58
jamie commented 2019-02-22 01:33:05 +00:00 (Migrated from git.hazaar.io)
Copy link

closed via commit bb24df2371

closed via commit bb24df2371650db889ce181ca734c5ea60f57e32
jamie commented 2019-02-22 05:59:35 +00:00 (Migrated from git.hazaar.io)
Copy link

mentioned in commit bb24df2371

mentioned in commit bb24df2371650db889ce181ca734c5ea60f57e32
jamie self-assigned this 2025-09-04 01:15:39 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
586-gitlab-ci-migration
297-feature-router-security
develop
No results found.
Labels
Clear labels   
bug

   
confirmed

   
critical

   
discussion

   
documentation

   
Doing

   
enhancement

   
experiment

Experimental Feature

  
suggestion

   
support

   
Testing

   
To Do
No labels
bug
confirmed
critical
discussion
documentation
Doing
enhancement
experiment
suggestion
support
Testing
To Do
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
jamie
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: hazaar/framework#160
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?