Fix updated calls to File\Manager::scandir() in File and File\Dir #235

Closed
opened 2021-03-16 23:20:34 +00:00 by jamie · 3 comments
jamie commented 2021-03-16 23:20:34 +00:00 (Migrated from git.hazaar.io)

Now that the Hazaar\File\Manager sits in between the Hazaar\File and Hazaar\File\Dir classes so that we can do failover, there are a couple of places I missed updating that still use Hazaar\File\Manager::scandir() in the old way. When it was the backend being called directly, the File/Dir class was responsible for generating the File/Dir objects. The manager does this now, so the few places that use scandir that haven't yet been updated still expect the returned array to contain strings.

Now that the `Hazaar\File\Manager` sits in between the `Hazaar\File` and `Hazaar\File\Dir` classes so that we can do failover, there are a couple of places I missed updating that still use `Hazaar\File\Manager::scandir()` in the old way. When it was the backend being called directly, the File/Dir class was responsible for generating the File/Dir objects. The manager does this now, so the few places that use `scandir` that haven't yet been updated still expect the returned array to contain strings.
jamie commented 2021-03-16 23:21:38 +00:00 (Migrated from git.hazaar.io)

mentioned in merge request !128

mentioned in merge request !128
jamie commented 2021-03-16 23:21:38 +00:00 (Migrated from git.hazaar.io)

created merge request !128 to address this issue

created merge request !128 to address this issue
jamie commented 2021-03-17 04:28:02 +00:00 (Migrated from git.hazaar.io)

mentioned in commit 303299b3f0432497eb6ad7f0d99a75fb27edd5b2

mentioned in commit 303299b3f0432497eb6ad7f0d99a75fb27edd5b2
jamie (Migrated from git.hazaar.io) closed this issue 2021-03-17 04:28:02 +00:00
jamie self-assigned this 2025-09-04 01:15:24 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: hazaar/framework#235
No description provided.