Schema migration with default value of zero (0) does not set default value #2

New issue

Closed

opened 2017-01-18 04:30:16 +00:00 by jamie · 5 comments

jamie commented

2017-01-18 04:30:16 +00:00

(Migrated from git.hazaar.io)

Take the following schema migration:

{
    "up": {
        "alter": {
            "table": {
                "request_form": {
                    "add": {
                        "from_fred": {
                            "name": "from_fred",
                            "ordinal_position": 12,
                            "default": 0,
                            "not_null": false,
                            "data_type": "integer",
                            "length": null,
                            "primarykey": false
                        }
                    }
                }
            }
        }
    },
    "down": {
        "alter": {
            "table": {
                "request_form": {
                    "drop": [
                        "from_FRED"
                    ]
                }
            }
        }
    }
}

This column will not be set with a default value. I think it is because the check for the default is borking on the check due to zero resolving to false or something.

Take the following schema migration: ``` { "up": { "alter": { "table": { "request_form": { "add": { "from_fred": { "name": "from_fred", "ordinal_position": 12, "default": 0, "not_null": false, "data_type": "integer", "length": null, "primarykey": false } } } } } }, "down": { "alter": { "table": { "request_form": { "drop": [ "from_FRED" ] } } } } } ``` This column will not be set with a default value. I think it is because the check for the default is borking on the check due to zero resolving to ```false``` or something.

jamie commented

2017-01-18 04:30:58 +00:00

(Migrated from git.hazaar.io)

added ~152 label

jamie commented

2017-04-01 00:07:01 +00:00

(Migrated from git.hazaar.io)

added ~160 label

jamie commented

2017-06-21 23:25:23 +00:00

(Migrated from git.hazaar.io)

Tested this with a new table and the default is set correctly. Might be only on a column add.