hazaar/hazaar-warlock
1
0
Fork 0
Code Issues Pull requests 2 Projects Releases 4 Packages Wiki Activity Actions

Downgrade duplicate subscribe from error to warning #13

New issue
Closed
opened 2017-03-22 04:10:48 +00:00 by jamie · 6 comments
jamie commented 2017-03-22 04:10:48 +00:00 (Migrated from git.hazaar.io)
Copy link

When a subscription event arrives we return false to indicate that the subscription failed. This is a throw back to the legacy long polling days when this was bad. Now with websockets this causes problems despite being totally OK. We should just ignore the request and instead, display a warning saying there was a SUBSCRIBE request for a trigger already subscribed to and then just return true.

When a subscription event arrives we return false to indicate that the subscription failed. This is a throw back to the legacy long polling days when this was bad. Now with websockets this causes problems despite being totally OK. We should just ignore the request and instead, display a warning saying there was a SUBSCRIBE request for a trigger already subscribed to and then just return true.
jamie commented 2017-03-22 23:59:23 +00:00 (Migrated from git.hazaar.io)
Copy link

created branch 13-downgrade-duplicate-subscribe-from-error-to-warning

created branch [`13-downgrade-duplicate-subscribe-from-error-to-warning`](https://git.hazaarlabs.com/hazaar/hazaar-warlock/compare/master...13-downgrade-duplicate-subscribe-from-error-to-warning)
jamie commented 2017-04-01 00:01:41 +00:00 (Migrated from git.hazaar.io)
Copy link

assigned to @jamie

assigned to @jamie
jamie commented 2017-04-01 00:02:01 +00:00 (Migrated from git.hazaar.io)
Copy link

added ~163 label

added ~163 label
jamie commented 2017-04-01 00:05:05 +00:00 (Migrated from git.hazaar.io)
Copy link

added ~164 and removed ~163 labels

added ~164 and removed ~163 labels
jamie commented 2017-04-01 00:05:46 +00:00 (Migrated from git.hazaar.io)
Copy link

closed

closed
jamie commented 2017-04-01 00:05:46 +00:00 (Migrated from git.hazaar.io)
Copy link

removed ~164 label

removed ~164 label
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
3.0-develop
58-restful-triggers
2.2-stable
2-warlock-to-warlock-communication
release-2.2.3
release-2.2.2
release-2.2.1
release-2.2.0
release-2.1.5
release-2.1.4
release-2.1.3
release-2.1.2
release-2.1.1
release-2.1.0
release-2.0.2
release-2.0.1
release-2.0.0
release-1.2.6
release-1.2.5
release-1.2.4
release-1.2.3
release-1.2.2
release-1.2.1
release-1.2.0
release-1.1.9
release-1.1.8
release-1.1.7
release-1.1.6
release-1.1.5
release-1.1.4
release-1.1.3
release-1.1.2
release-1.1.1
release-1.1.0
release-1.0.6
release-1.0.5
release-1.0.4
release-1.0.3
release-1.0.2
release-1.0.1
release-1.0.0
release-0.4.0
release-0.3.0
release-0.2.0
release-0.1.0
Labels
Clear labels   
bug

   
confirmed

   
critical

   
discussion

   
documentation

   
Doing

   
enhancement

   
suggestion

   
support

   
To Do
No labels
bug
confirmed
critical
discussion
documentation
Doing
enhancement
suggestion
support
To Do
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: hazaar/hazaar-warlock#13
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?