Test: Re-subscribe on re-connect #41

New issue

Closed

opened 2019-03-06 03:35:45 +00:00 by jamie · 2 comments

jamie commented

2019-03-06 03:35:45 +00:00

(Migrated from git.hazaar.io)

The issue here is, do we automatically re-subscribe to any subscriptions the client had previously requested? if not, this is something we will need to fix up.

Something I need to test and fix if it's actually an issue. A client will connect to the server, then they may be disconnected for some reason at which point it is possible that any subscriptions are deleted by the server if it too registers the disconnect. Or even, if the server restarts and the client automatically reconnects. The issue here is, do we automatically re-subscribe to any subscriptions the client had previously requested? if not, this is something we will need to fix up.

jamie commented

2019-03-06 23:23:52 +00:00

(Migrated from git.hazaar.io)

This was actually almost already implemented. The reason it wasn't working was because the re-subscribe only happened when loading the initial packet, which didn't happen on a reconnect because we already knew the packet types. So now we do a different test for the initial packet which allows us to re-subscribe. We can also reload the packet types in case they change as well.

jamie commented

2020-04-14 23:30:32 +00:00

(Migrated from git.hazaar.io)

mentioned in commit 35b1077af6

mentioned in commit 35b1077af6810b5d5200d7dd7f9a81e39d3e9800